Skip to content
This repository was archived by the owner on Nov 6, 2019. It is now read-only.

Disable autoplay policy enforcement in Chrome #552

Open
jugglinmike wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable autoplay policy enforcement in Chrome #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/master/wpt_run_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ def makeWptRunCommand(properties):
# Chrome to call getUserMedia without failing out.
command.extend([
'--binary-arg=--use-fake-ui-for-media-stream',
'--binary-arg=--use-fake-device-for-media-stream'
'--binary-arg=--use-fake-device-for-media-stream',
Copy link
Copy Markdown
Collaborator

@jgraham jgraham May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I wish we would put these flags in wptrunner directly rather than having special configuration here.

Copy link
Copy Markdown
Collaborator Author

@jugglinmike jugglinmike May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. That feature needs a bit more definition before I can implement it, so I've opened gh-10823 to discuss it further.

Copy link
Copy Markdown
Collaborator Author

@jugglinmike jugglinmike May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...which is in another repository, so I'll need a URL:

web-platform-tests/wpt#10823

# See
# https://developers.google.com/web/updates/2017/09/autoplay-policy-changes
'--binary-arg=--autoplay-policy=no-user-gesture-required'
Copy link
Copy Markdown

@mounirlamouri mounirlamouri May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

])

command.append(browser_id)
Expand Down