Set a viewport meta tag to a intersection observer test #15254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid the content is zoomed out and to avoid expanding the layout viewport to the minimum-scale size. On mobile without specifying the viewport meta tag, the target element, positioned at the center of the contents, is initially visible because the content is zoomed out to some extent. But the test supposes that the target element is scrolled out of view in the first place and is moved into the root margin after setting scrollLeft to 100 in step0(). Thus all subsequent test cases don't work as expected.
|
This test fail on Firefox on Android. @szager-chromium would you mind reviewing this? Unfortunately there is no reasonable person to review this in Mozilla at this moment (the change itself is trivial though). |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 6, 2019
… case fail. r=heycam All of failure test cases in root-margin.html will be fixed by this PR web-platform-tests/wpt#15254 . Differential Revision: https://phabricator.services.mozilla.com/D18760 --HG-- extra : moz-landing-system : lando
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
… case fail. r=heycam All of failure test cases in root-margin.html will be fixed by this PR web-platform-tests/wpt#15254 . Differential Revision: https://phabricator.services.mozilla.com/D18760 UltraBlame original commit: 241a3659869bd944111ee48233ba27ceb2040af7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
… case fail. r=heycam All of failure test cases in root-margin.html will be fixed by this PR web-platform-tests/wpt#15254 . Differential Revision: https://phabricator.services.mozilla.com/D18760 UltraBlame original commit: 241a3659869bd944111ee48233ba27ceb2040af7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
… case fail. r=heycam All of failure test cases in root-margin.html will be fixed by this PR web-platform-tests/wpt#15254 . Differential Revision: https://phabricator.services.mozilla.com/D18760 UltraBlame original commit: 241a3659869bd944111ee48233ba27ceb2040af7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the content is zoomed out and to avoid expanding the layout viewport
to the minimum-scale size.
On mobile without specifying the viewport meta tag, the target element,
positioned at the center of the contents, is initially visible because the
content is zoomed out to some extent. But the test supposes that the target
element is scrolled out of view in the first place and is moved into the
root margin after setting scrollLeft to 100 in step0(). Thus all subsequent
test cases don't work as expected.