Adding a new test to cover changes to sendkeys() discussed for the spec #17664
Conversation
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
| @@ -42,6 +43,20 @@ def test_input_append(session): | |||
| assert element.property("value") == "abc" | |||
|
|
|||
|
|
|||
| def test_input_append_with_focus(session): | |||
There was a problem hiding this comment.
We should also have this test for the content editable elements. See the other file in this folder.
There was a problem hiding this comment.
I think this still has to be done.
| assert element.property("value") == "a" | ||
|
|
||
| element_send_keys(session, element, "b") | ||
| assert element.property("value") == "ab" |
There was a problem hiding this comment.
Just set ab as value directly, so that we don't need those two lines.
There was a problem hiding this comment.
Sorry for the delay, I missed your comment. I'm doing this specifically to verify that even though a is already there (and verified), when I send "b" via sendkeys, the letter "a" is not deleted.
There was a problem hiding this comment.
I see. So give that this test is about appending, can you move out the case for inserting, or modify the test name?
|
What is left to land this PR? I'd like to fix Safari's behavior and verify with the test. |
No description provided.