-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to run servers on different IP addresses. #28768
base: master
Are you sure you want to change the base?
Conversation
Seems that macOS indeed failed to start the additional servers. Windows on the other hand seems to have failed some tests due to them overriding |
Attempted to fix Windows test failures. Along the way, I changed the way the server config is passed to WebDriver tests. Instead of serializing the whole config in an environment variable, I amended the code to dump the config as JSON in a temporary file (the tests are conveniently executed against a temporary directory) and pass the file path in the environment variable instead. This avoids repeatingly bumping into the 16-bit environment variable length limitation on Windows, and the need to special-case origin-policy subdomains. I also added the py39 environment to |
Removed the |
So my high level impression is that this looks quite reasonable. It might make sense to break the WebDriver config change into a seperate PR since that's somewhat orthogonal (and much less risky) than the rest of the changes. I think we're going to need to run this one through a full trigger run and in vendor CI to ensure we're not accidentially breaking anything. |
@letitz do you know how you'd run this through Chromium's CI to look for regressions? If not let me know and I'm happy to chat. (We might have to update our copy of tools/ for the patch to apply and for the comparison to be meaningful.) |
@foolip I'm not sure. My first thought was that I could download a patch version of this PR, apply it in a Chomium client and run CI jobs on the resulting patch. However, the How do you maintainers usually do this? |
This PR adds two new
alternate_hosts
to the default test configuration:private
:private-web-platform.test
public
:public-web-platform.test
These are hosted by a collection of new servers bound to different IP addresses (
127.1.0.1
and127.2.0.1
respectively). All protocols and subdomains are supported. This results in a ~3x increase in the size of./wpt make-hosts-file
's output.These new IP addresses are configurable using a new config property:
alternate_ip_addresses
, which maps host names to IP addresses.Sending this for review now, but there is one last thing I need to fix: this probably does not work macOS, as noted in web-platform-tests/rfcs#79.