[WPT] Move/merge COEP/COOP dispatcher framework to /common #29684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 16, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3033199
branch
from
64fc95b to
80eae9a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3033199
branch
2 times, most recently
from
ab98d33 to
955af39
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3033199
branch
2 times, most recently
from
82c67b6 to
be54c06
Compare
This was referenced Sep 10, 2021
Closed
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3033199
branch
3 times, most recently
from
b918344 to
83cae27
Compare
To reduce duplication and prepare for using this framework for BFCache (#28950), this CL merges two sets of dispatcher/executor files under COEP and COOP and move them to `/common`. Relevant discussion is also in web-platform-tests/rfcs#89. Most of the changes are simple path renaming, except for: - Service worker's scope is also moved to `/common/dispatcher/` in: /wpt/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.tentative.https.html /wpt/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.tentative.https.html /wpt/html/cross-origin-opener-policy/popup-coop-by-sw.https.html because the service workers should control executors. - Diffs between COEP and COOP dispatchers are merged, but are trivial (e.g. some functionality exists only one of them, like 6 concurrent accesses to the server, retrying on failure, Access-Control-Allow-Credentials in dispatcher, etc.). - Reporting-related part of `dispatcher.js` is moved to /wpt/html/cross-origin-opener-policy/reporting/resources/reporting-common.js. - README.md about the dispatcher is moved and added. - /wpt/html/cross-origin-embedder-policy/credentialless/resources/cacheable-response.py is also merged into dispatcher.py, because they should access the same stash and already have common code. - Stash paths are moved to '/common/dispatcher'. - `executer.js` and `sw_executer.js` are moved to `executer-worker.js` and `executer-service-worker.js`, respectively, to clarify they are worker scripts, rather than helpers. - Timeout in receive() is removed because no one uses that parameter. - Duplicated/unused const declarations are removed. Bug: 1107415 Change-Id: I0d28e7f4b4cca6599562ac4766a326880139028d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033199 Commit-Queue: Hiroshige Hayashizaki <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/main@{#921511}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3033199
branch
from
83cae27 to
03f90d6
Compare
|
I think the failures on wpt.fyi runs and chrome-dev-stability are due to existing flakiness. |
|
This test is flaky in chromium. WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
|
@past can you admin merge this? The author explained those are existing flakiness, so I guess we don't need to file a crbug for him/her. |
|
Probably https://bugs.chromium.org/p/chromium/issues/detail?id=1205423 is for the same issue. cc/ @ArthurSonzogni |
|
Merged, thanks! |
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…orm-tests#29684) To reduce duplication and prepare for using this framework for BFCache (web-platform-tests#28950), this CL merges two sets of dispatcher/executor files under COEP and COOP and move them to `/common`. Relevant discussion is also in web-platform-tests/rfcs#89. Most of the changes are simple path renaming, except for: - Service worker's scope is also moved to `/common/dispatcher/` in: /wpt/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.tentative.https.html /wpt/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.tentative.https.html /wpt/html/cross-origin-opener-policy/popup-coop-by-sw.https.html because the service workers should control executors. - Diffs between COEP and COOP dispatchers are merged, but are trivial (e.g. some functionality exists only one of them, like 6 concurrent accesses to the server, retrying on failure, Access-Control-Allow-Credentials in dispatcher, etc.). - Reporting-related part of `dispatcher.js` is moved to /wpt/html/cross-origin-opener-policy/reporting/resources/reporting-common.js. - README.md about the dispatcher is moved and added. - /wpt/html/cross-origin-embedder-policy/credentialless/resources/cacheable-response.py is also merged into dispatcher.py, because they should access the same stash and already have common code. - Stash paths are moved to '/common/dispatcher'. - `executer.js` and `sw_executer.js` are moved to `executer-worker.js` and `executer-service-worker.js`, respectively, to clarify they are worker scripts, rather than helpers. - Timeout in receive() is removed because no one uses that parameter. - Duplicated/unused const declarations are removed. Bug: 1107415 Change-Id: I0d28e7f4b4cca6599562ac4766a326880139028d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033199 Commit-Queue: Hiroshige Hayashizaki <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/main@{#921511} Co-authored-by: Hiroshige Hayashizaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce duplication and prepare for using this framework for BFCache
(#28950),
this CL merges two sets of dispatcher/executor files under COEP and COOP
and move them to
/common.Relevant discussion is also in
web-platform-tests/rfcs#89.
Most of the changes are simple path renaming, except for:
/common/dispatcher/in:/wpt/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.tentative.https.html
/wpt/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.tentative.https.html
/wpt/html/cross-origin-opener-policy/popup-coop-by-sw.https.html
because the service workers should control executors.
(e.g. some functionality exists only one of them, like
6 concurrent accesses to the server, retrying on failure,
Access-Control-Allow-Credentials in dispatcher, etc.).
dispatcher.jsis moved to/wpt/html/cross-origin-opener-policy/reporting/resources/reporting-common.js.
is also merged into dispatcher.py, because
they should access the same stash and already have common code.
executer.jsandsw_executer.jsare moved toexecuter-worker.jsandexecuter-service-worker.js, respectively,to clarify they are worker scripts, rather than helpers.
Bug: 1107415
Change-Id: I0d28e7f4b4cca6599562ac4766a326880139028d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033199
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#921511}