[webdriver] Add character typing tests #32679

AutomatedTester · 2022-02-03T21:22:38Z

No description provided.

webdriver/tests/element_send_keys/send_keys.py

whimboo · 2022-02-07T15:19:55Z

webdriver/tests/element_send_keys/send_keys.py

+    [u'\ue028', "."],
+    [u'\ue029', "/"],
+    [u'\ue01a', "0"],
+    [u'\ue023', "9"]


Question: What about all the other numbers? Also it misses \ue026

I didn't add all the values because wpt times out the test file if there are a lot of parametrised values. I can raise an issue but I can't solve that issue in this test PR.

Ah that one. Now I remember. Do you actually have a link to such a job in the wpt CI? I would be interested in. But yes it's fine to file an issue and add a TODO comment here with a link to that issue.

Do you have such a link to a broken job in CI?

I didn't put it through CI. It was timing out locally. I assumed it would do the same locally as on the CI

As discussed yesterday the underlying problem with Chrome is gone and personally I also do not see any timeout when running way more parameterized tests with Chrome. So I would suggest that we do not land the patch in a rush but get coverage for all the normalized keys.

I'm happy to update the PR in case you don't have the time for.

I have added a few more. I think it's important to get this landed than make sure we have all the cases covered and we can add cases later when someone has time

Ok, I can see that Chrome and also Firefox is running into a timeout. When I have a look at the trace logs at least for Firefox locally I can see that there is not that much of an improvement that we can do beside the following:

Use a # META: timeout=long line at the very top which in this case would be fine to do.

For tests where we can combine characters lets do it so that we can safe the time as needed for setup/teardown and especially loading the test page.

Think about actually loading real data URIs instead of inline docs which will still be routed through wptserve.

Especially 2) will help a lot here given that we spend 50% of the test's time in setup/teardown.

whimboo · 2022-02-07T15:20:33Z

webdriver/tests/element_send_keys/send_keys.py

+    [u'\ue01a', "0"],
+    [u'\ue023', "9"]
+    ])
+def test_normalised_key_value(session, inline, value):


This test doesn't cover all the normalized keys. Maybe add printable to the test name?

I could but I don't see value in that. It's only printable because I limited the characters due to timeouts happening in the tests if there are more parametrised values.

Non-printable keys won't be testable this way and we might have to use an event listener instead to ensure that the correct key got pressed. As such you cannot just extend the parameterized list.

Co-authored-by: Henrik Skupin <[email protected]>

webdriver/tests/element_send_keys/send_keys.py

whimboo · 2022-02-14T10:34:45Z

webdriver/tests/element_send_keys/send_keys.py

+    [u'\ue028', "."],
+    [u'\ue029', "/"],
+    [u'\ue01a', "0"],
+    [u'\ue023', "9"]


Do you have such a link to a broken job in CI?

webdriver/tests/element_send_keys/send_keys.py

review fix Co-authored-by: Henrik Skupin <[email protected]>

AutomatedTester · 2022-02-18T11:21:06Z

@whimboo I've update things based on your comments

whimboo · 2022-02-18T12:57:05Z

@AutomatedTester mind to also check my other comments where I'm awaiting a reply for? #32679 (comment) thanks

whimboo · 2022-03-02T10:20:45Z

webdriver/tests/element_send_keys/send_keys.py

+@pytest.mark.parametrize("value",[
+    [u'\ue018', ";"],


What I didn't notice before I actually run these tests locally was that for parameterization you have to use tuples. At least for me pytest complains about that. Also it avoids to have to call the indices.

Suggested change

@pytest.mark.parametrize("value",[

[u'\ue018', ";"],

@pytest.mark.parametrize("value, expected",[

(u'\ue018', ";"),

whimboo · 2022-03-02T10:22:48Z

webdriver/tests/element_send_keys/send_keys.py

+    [u'\ue028', "."],
+    [u'\ue029', "/"],
+    [u'\ue01a', "0"],
+    [u'\ue023', "9"]


As discussed yesterday the underlying problem with Chrome is gone and personally I also do not see any timeout when running way more parameterized tests with Chrome. So I would suggest that we do not land the patch in a rush but get coverage for all the normalized keys.

I'm happy to update the PR in case you don't have the time for.

whimboo · 2022-03-02T10:23:10Z

webdriver/tests/element_send_keys/send_keys.py

+    # TODO This is not extensive list due to timeouts from wpt if there are a lot of test
+    # See https://github.com/web-platform-tests/wpt/issues/32899


This issue is no longer needed I assume and we can close?

I still hit this issue in Chrome.

I parameterized the bottom test case in the file and that hits it on my local machine with chrome.

AutomatedTester · 2022-03-08T12:06:30Z

Timed out in https://wpt.fyi/results/webdriver/tests/element_send_keys/send_keys.py?diff&filter=ADC&run_id=5134319369584640&run_id=5745127371833344

whimboo · 2022-05-17T21:49:44Z

@AutomatedTester sorry but it looks like we or I dropped the ball a while ago for this pull request. Could you please check what's left to do so that we can get it landed? There are a couple of open issues, and not sure which are resolved and which are not. Thanks.

whimboo · 2023-02-24T09:08:51Z

@AutomatedTester it's been a while and I would like to know if you are still interested in these tests. There is a conflict as well. Thanks.

[webdriver] Add character typing tests

798162b

wpt-pr-bot added webdriver wg-testing_browser labels Feb 3, 2022

wpt-pr-bot assigned whimboo Feb 3, 2022

AutomatedTester mentioned this pull request Feb 3, 2022

[🐛 Bug]: Send_keys does not accept underscore when I use chromedriver 98 SeleniumHQ/selenium#10318

Closed

valfirst approved these changes Feb 4, 2022

View reviewed changes

15minutOdmora approved these changes Feb 4, 2022

View reviewed changes

andresfr84 approved these changes Feb 4, 2022

View reviewed changes

LorenzoScebba approved these changes Feb 5, 2022

View reviewed changes

whimboo requested changes Feb 7, 2022

View reviewed changes

AutomatedTester and others added 3 commits February 7, 2022 18:31

review comment

573f6b0

Co-authored-by: Henrik Skupin <[email protected]>

updated with review comment

830d423

Co-authored-by: Henrik Skupin <[email protected]>

add non-printable test and Todo comment

a032d93

wpt-pr-bot requested review from jgraham and shs96c February 9, 2022 15:27

whimboo reviewed Feb 14, 2022

View reviewed changes

Update webdriver/tests/element_send_keys/send_keys.py

fb9991e

review fix Co-authored-by: Henrik Skupin <[email protected]>

AutomatedTester mentioned this pull request Feb 18, 2022

wpt runner hits timeout after 30 seconds if a file has a lot of test cases #32899

Closed

fix review comments

59a6576

whimboo requested changes Mar 2, 2022

View reviewed changes

comment fixes

9887c28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webdriver] Add character typing tests #32679

[webdriver] Add character typing tests #32679

AutomatedTester commented Feb 3, 2022

whimboo Feb 7, 2022

AutomatedTester Feb 7, 2022 •

edited

Loading

whimboo Feb 7, 2022

whimboo Feb 14, 2022

AutomatedTester Feb 20, 2022

whimboo Mar 2, 2022

AutomatedTester Mar 7, 2022

whimboo Mar 8, 2022

whimboo Feb 7, 2022

AutomatedTester Feb 7, 2022

whimboo Feb 7, 2022

whimboo Feb 14, 2022

AutomatedTester commented Feb 18, 2022

whimboo commented Feb 18, 2022

whimboo Mar 2, 2022

AutomatedTester Mar 7, 2022

whimboo Mar 2, 2022

whimboo Mar 2, 2022

AutomatedTester Mar 7, 2022

AutomatedTester Mar 7, 2022

AutomatedTester commented Mar 8, 2022

whimboo commented May 17, 2022

whimboo commented Feb 24, 2023

		# TODO This is not extensive list due to timeouts from wpt if there are a lot of test
		# See https://github.com/web-platform-tests/wpt/issues/32899

[webdriver] Add character typing tests #32679

Are you sure you want to change the base?

[webdriver] Add character typing tests #32679

Conversation

AutomatedTester commented Feb 3, 2022

Choose a reason for hiding this comment

AutomatedTester Feb 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutomatedTester commented Feb 18, 2022

whimboo commented Feb 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutomatedTester commented Mar 8, 2022

whimboo commented May 17, 2022

whimboo commented Feb 24, 2023

AutomatedTester Feb 7, 2022 •

edited

Loading