-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Modified and corrected CSS2/box-display/containing-block-017.xht #38687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rather than removing the testcase, move it to the css-position/ folder so it can serve as a test for [css-position-3] Containing block formed by fragmented inlines w3c/csswg-drafts#8284 and add this new one.
- In the new CSS2 testcase, use background-image to position the red squares and to make the reference file. Since CSS2 doesn't have multiple background images, you will need an extra wrapper SPAN around #test to hold one of the background images.
- Since we're testing single-line content, shorten the words on the line and remove the div's width so that the text doesn't wrap if the font changes to something wider.
- There is no need to rename any of the selectors, they were fine.
- You can remove the comments about left-to-right. If we want a right-to-left test, we should include it in this file. (In this case, we would have to change the selectors from # to .)
When I am able to submit-git-push a commit that will include a reference file as well, I will move the improved containing-block-017 test to the css-position/ folder Done at my website:
I agree that we should try to use a background-image for displaying the red squares. So far, I have not succeeded. I am still working on this.
So far, I have not succeeded. I am still working on this.
Done. The words
Done. I also changed the border color of the div.
I have renamed the selectors back to what they were in the original containing-block-017.xht test:
http://www.gtalbot.org/BrowserBugsSection/CSS3PositionedLayout/newer-containing-block-017.xht
I have removed the comments about left-to-right Additionnally:
|
I tried to implement your proposal above but could not. See http://www.gtalbot.org/BrowserBugsSection/CSS3PositionedLayout/draft-containing-block-017.xht Vertical margins (margin-top, margin-bottom) have no effect on non-replaced inline elements and css width and css height do not apply either on non-replaced inline elements. |
At my website: http://www.gtalbot.org/BrowserBugsSection/CSS3PositionedLayout/newest-containing-block-017.xht Somehow, it does not seem possible to keep the "TL" and "BR" text in the reference file. I added a few minor comments in the test to explain some values. |
One Continuous Integration check, wpt-decision-task, failed and I do not know why. I will close this PR and will create another one, hoping that it will succeed. |
Previous containing-block-017.xht test:
https://wpt.live/css/CSS2/box-display/containing-block-017.xht
or (at my website)
http://www.gtalbot.org/BrowserBugsSection/css22testsuite/previous-CSS2-box-display-containing-block-017.xht
New containing-block-017.xht test replacing previous:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/new-containing-block-017.xht
Notes:
margin-bottom: 20px
at line 16 because it was useless, pointless, unneeded, irrelevantfont-size: 20px; line-height: 30px;
because, right now, this new and replacing test (just like the previous test) has no reference file. I tried to create a reference file for it but it is not obvious, it is tricky to do and it would require more thinking, conception time. If one day a reference file can be created, it should (otherwise will definitely) benefit from having already a definedfont-size
andline-height
declarationsspan#containing-block
, between line 71 and line 72http://www.gtalbot.org/BrowserBugsSection/css22testsuite/previous-CSS2-box-display-containing-block-017.xht
so that we can try to adjust it or improve it or rehabilitate it once Issue 8284 has been resolved and then to add it into CSS3 Positioned Layout test suite
[RC6] containing-block-017 : proposed improvements (9 Mar 2012)
https://lists.w3.org/Archives/Public/public-css-testsuite/2012Mar/0008.html