[Gecko Bug 1821188] Enable WebTransport H3 server for web-platform tests #39682
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
serve
wpt
wptrunner
wpt-pr-bot
approved these changes
Apr 25, 2023
Differential Revision: https://phabricator.services.mozilla.com/D172062 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1821188 gecko-commit: b6338cc8ab861480c5661251bc578aae8e0f5648 gecko-reviewers: ahochheiden
lutien
force-pushed
the
gecko/1821188
branch
from
698f9be to
9c41521
Compare
jgraham
requested changes
Sep 7, 2023
There was a problem hiding this comment.
This change makes me nervous.
I don't think we should be defaulting enable-webstransport-h3 to True for all browsers without an RFC. I'm also not sure we should be requiring binary deps for all wptrunner configurations again without ensuring that works for everyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D172062
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1821188
gecko-commit: b6338cc8ab861480c5661251bc578aae8e0f5648
gecko-reviewers: ahochheiden