[fetch-later] Add FetchLaterParams into network::mojom::URLRequest.
#41842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 6, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4803083
branch
4 times, most recently
from
c868618 to
09c721c
Compare
Sequence Diagram: https://docs.google.com/document/d/1U8XSnICPY3j-fjzG35UVm6zjwL6LvX6ETU3T8WrzLyQ/edit#heading=h.y51nt9atd97v - Replace `URLRequest::is_fetch_later_api` with `URLRequest::fetch_later_params`. - Define `FetchLaterPrams`, which includes a pending_remote of FetchLaterClient. - Define `FetchLaterClient`, which supports `SetFetchLaterHost()` and `Clone()`. The former should be implemented in blink to support Renderer->Browser communication. - Define `FetchLaterHost`, which is implemented by every KeepAliveURLLoader. It supports a one-time method `SendNow()` and `Abort()`. - Aborting a FetchLater request right after calling fetchLater(), and then disposing a page, can introduce race condition, such that the browser still send out the request. In KeepAliveURLLoader, it tries to mitigate this by looking into the custom disconnection reason from the remote of FetchLaterClient. But the race can still happen. OT info will include this problem. See the "Renderer->Browser Communication" section [1] for the details and other considered alternatives. Subsequent CL https://crrev.com/c/4803283 will use this interface to implement fetchLater()'s backgroundTimeout feature. [1]: https://docs.google.com/document/d/1U8XSnICPY3j-fjzG35UVm6zjwL6LvX6ETU3T8WrzLyQ/edit#heading=h.15fe7ufeo4uv Bug: 1465781 Change-Id: Ib5067de1a10478cd0bb16ff6c4d981872bf5c1a6
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4803083
branch
from
09c721c to
6e901b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequence Diagram: https://docs.google.com/document/d/1U8XSnICPY3j-fjzG35UVm6zjwL6LvX6ETU3T8WrzLyQ/edit#heading=h.y51nt9atd97v
URLRequest::is_fetch_later_apiwithURLRequest::fetch_later_params.FetchLaterPrams, which includes a pending_remote ofFetchLaterClient.
FetchLaterClient, which supportsSetFetchLaterHost()andClone(). The former should be implemented in blink to supportRenderer->Browser communication.
FetchLaterHost, which is implemented by everyKeepAliveURLLoader. It supports a one-time method
SendNow()andAbort().then disposing a page, can introduce race condition, such that the
browser still send out the request. In KeepAliveURLLoader, it tries
to mitigate this by looking into the custom disconnection reason
from the remote of FetchLaterClient. But the race can still happen.
OT info will include this problem.
See the "Renderer->Browser Communication" section 1 for the details
and other considered alternatives.
Subsequent CL https://crrev.com/c/4803283 will use this interface to
implement fetchLater()'s backgroundTimeout feature.
Bug: 1465781
Change-Id: Ib5067de1a10478cd0bb16ff6c4d981872bf5c1a6
Reviewed-on: https://chromium-review.googlesource.com/4803083
WPT-Export-Revision: 9440dfbb3d9c37fcb94e9ec5033f9a37a12586e8