Enable shadowrealm testing for dom events api #41966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's block on this as per #41985. |
49 tasks
The non-ShadowRealm version of these tests rely on document.createEvent() which is not exposed in ShadowRealms. Add separate tests for ShadowRealm scopes that use the Event constructor instead of document.createEvent(). For the cancelBubble test, we cannot actually test the bubbling behaviour without a DOM, but the property still must exist. Also, make sure to expose the export on globalThis in the support script.
This adds a copy of the test in Event-propagation.html, but on a plain EventTarget instead of a DOM node. The difference is that EventTarget doesn't have bubbling/capture behaviour, so the expectations after stopPropagation() and cancelBubble=true are different. This test can be run in every global scope where EventTarget is available, not just in ShadowRealm.
Add assertion messages, fix typo. These are here because I've added additional variants of these tests for ShadowRealm and have made the same changes in the new tests.
ptomato
force-pushed
the
rwaldron/shadowrealm-dom-events-api-tests
branch
from
b5ac50c to
cd8e252
Compare
annevk
reviewed
Nov 14, 2024
|
@annevk Sure, I can do that. I did it this way initially, because I assumed we'd still want to keep the existing test coverage of events being created with |
|
Tests that cannot be generalized should be kept. They could potentially be moved to a |
|
This is done in #49211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.