Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An element in an iframe with a transform should be interactable #44205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gsnedders
Copy link
Member

No description provided.

@whimboo
Copy link
Contributor

whimboo commented Jan 26, 2024

There was a discussion on Matrix.

As noted by @jgraham the two newly added tests are failing (can also be seen in the wpt.fyi results) as expected because the input element was outside the viewport, even though the entire div wasn't.

If we want to keep this tests we should change the expectation to not interactable.

@gsnedders
Copy link
Member Author

gsnedders commented Feb 8, 2024

There was a discussion on Matrix.

As noted by @jgraham the two newly added tests are failing (can also be seen in the wpt.fyi results) as expected because the input element was outside the viewport, even though the entire div wasn't.

If we want to keep this tests we should change the expectation to not interactable.

The discussion on Matrix was about the existing tests in this file; not about the new tests here.

https://wpt.fyi/results/webdriver/tests/classic/element_click/interactability.py?label=pr_head&max-count=1&pr=44205 is the current results for the file in the PR: the new tests are the parametrised test_element_interactable_in_iframe_with_css_transform which fail only in Chrome.

That said, it is the case the button is outside of the top level browsing context's viewport, but it's unclear whether the spec actually really covers this. As far as I can tell, we only check that the element being clicked on is "in view", and not whether the browsing context owning it is in view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants