Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wdspec] Add wait_for_events fixture to wait for several BiDi events #44812

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[wdspec] Add wait_for_events fixture to wait for several BiDi events #44812

wants to merge 3 commits into from

Conversation

juliandescottes
Copy link
Contributor

Fixes #44702

@juliandescottes juliandescottes marked this pull request as draft February 27, 2024 11:55
@juliandescottes
Copy link
Contributor Author

This PR is adding 2 new fixtures:

  • wait_for_event_expectation
  • wait_for_events

The first one, wait_for_event_expectation, allows to wait an event expectation which is basically composed of an event name event, an expected count (optional, defaults to 1), and a filter lambda filter.

wait_for_events reuses wait_for_event_expectation in order to wait for several of those expectations, in sequence.

The original wait_for_event is updated to reuse wait_for_event_expectation.

@juliandescottes juliandescottes force-pushed the add-wait_for_events-fixture branch from beffe30 to c6a8d64 Compare February 27, 2024 22:10
@juliandescottes
Copy link
Contributor Author

The test changes in the PR are just here as an example of how to use the API.
I had a few race conditions on Chrome with the previous version, so I will wait until CI seems relatively happy before sending for review.

@juliandescottes juliandescottes mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@jrandolf-2 jrandolf-2 Awaiting requested review from jrandolf-2

@sadym-chromium sadym-chromium Awaiting requested review from sadym-chromium

@shs96c shs96c Awaiting requested review from shs96c

@whimboo whimboo Awaiting requested review from whimboo

At least 1 approving review is required to merge this pull request.

Assignees

@jrandolf-2 jrandolf-2

Labels
webdriver wg-testing_browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wdspec] add fixture to wait for several WebDriver BiDi events
3 participants
@juliandescottes @wpt-pr-bot @jrandolf-2