Add test to verify that document.currentScript.src should not get clobbered by a DOM element with name='currentScript'. #48536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bbered by a DOM element with name='currentScript'. See whatwg/html#10687 for details.
annevk
reviewed
Oct 9, 2024
| <script> | ||
| test(function() { | ||
| assert_true(document.currentScript.tagName === 'SCRIPT'); // In particular, should not be "IMG" from the DOM element | ||
| assert_true(!document.currentScript.src.includes('malevolent_address')); // Should not have gotten the URL address from IMG element |
| test(function() { | ||
| assert_true(document.currentScript.tagName === 'SCRIPT'); // In particular, should not be "IMG" from the DOM element | ||
| assert_true(!document.currentScript.src.includes('malevolent_address')); // Should not have gotten the URL address from IMG element | ||
| assert_true(document.currentScript.src == ''); // In fact, since this is an inline <script> element, .src should be empty. |
There was a problem hiding this comment.
assert_equals would give a clearer error message here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to verify that document.currentScript.src should not get clobbered by a DOM element with name='currentScript'. See whatwg/html#10687 for details.
This is still pending browser vendor discussion, adding a test early to illustrate what it would look like.