[wdspec] change test_..._closes_browsing_context

[sadym-chromium]

Classic tests. Open context with window.open to allow it to be closed by script.

[sadym-chromium]

@whimboo it looks like this functionality does not work properly on ChromeDriver Classic, so I cannot verify if the test actually works. Could you please confirm it works for Firefox?

[whimboo]

Sorry for the delay. I commented yesterday but forgot to actually submit the comments.

[whimboo]

LGTM. Just a small nit. Could you check why the Chrome stability job is failing?

[whimboo]

Actually the tests for Firefox are failing because the input element cannot be located. We should actually wait until the page in the new window is loaded, or the element is present.

[whimboo]

@sadym-chromium actually something is wrong with your implementation of https://w3c.github.io/webdriver/#new-window. When a new tab gets opened by chromedriver I can see about:blank in the session history, which actually prevents closing the window because session history entry size is 2. Why is about:blank added to the session history?

[sadym-chromium]

@sadym-chromium actually something is wrong with your implementation of https://w3c.github.io/webdriver/#new-window. When a new tab gets opened by chromedriver I can see about:blank in the session history, which actually prevents closing the window because session history entry size is 2. Why is about:blank added to the session history?

I assume this is not related to this tests, as we don't use "POST /session/{session id}/window/new" in the test, but open a new window via web API

[sadym-chromium]

@sadym-chromium actually something is wrong with your implementation of https://w3c.github.io/webdriver/#new-window. When a new tab gets opened by chromedriver I can see about:blank in the session history, which actually prevents closing the window because session history entry size is 2. Why is about:blank added to the session history?

I filed a related ChromeDriver issue: https://crbug.com/390100762

[whimboo]

I filed a related ChromeDriver issue: https://crbug.com/390100762

Hm, this is not what I'm referring to. The test actually fails the assertion in Chrome because the window is not closed. Please run window.open("about:blank", "_blank", "chrome,menubar,resizable,scrollbars,status,toolbar") manually in Chrome and then load a new URL in that opened window. You can see that about:blank is not added to the session history of this tab. Running the same steps with Chromedriver adds about:blank to the session history when navigating to a different page (like the test page).

[OrKoN]

@sadym-chromium indeed, I think if navigation happens from about:blank, the URL navigated to should replace https://html.spec.whatwg.org/#the-navigation-must-be-a-replace the about:blank, thus making it script-closable due to the history entry size staying 1.

[whimboo]

Now that a window gets opened by the script we do no longer need the http_new_tab fixture here and in all the other tests.

Suggested change

	session, configuration, http_new_tab, inline, key_chain
	session, configuration, inline, key_chain

[whimboo]

This is still failing Firefox tests because none of the tests are waiting for the navigation to be completed. We need to wait for the input element to have the focus before we can start performing the action.