[Gecko Bug 1942190] part 2: Add WPT to test 'details'/'summary' with display:inline and inline-block. #50134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nline-block. This test passes in Chrome 134 dev, Safari Tech Preview 18.2, and Firefox Nightly 136 (but only with the pref-flip from the previous patch in this series). Differential Revision: https://phabricator.services.mozilla.com/D234616 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1942190 gecko-commit: 1e3dec2f84defef3bd2a8fa9521d14e6b8ff8c35 gecko-reviewers: TYLin
…ny special styling on ::details-content. This test leaves ::details-content unstyled, which per spec means that the ::details-content should generate a 'display:block' wrapper around the details-text. The reference case mimics this by simply adding an unstyled div around that text. This test passes in Chrome 134 dev and Safari Tech Preview 18.2. It fails in Firefox because Firefox doesn't support ::details-content yet; and in particular, Firefox doesn't automatically generate any wrapper-box for that pseudo-element, and the lack-of-that-box leads to the wrong rendering. Differential Revision: https://phabricator.services.mozilla.com/D234617 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1942190 gecko-commit: 5a74fd9392bad7b40efce636e024c4a8aa215dc0 gecko-reviewers: TYLin
wpt-pr-bot
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test passes in Chrome 134 dev, Safari Tech Preview 18.2,
and Firefox Nightly 136 (but only with the pref-flip from the
previous patch in this series).
Differential Revision: https://phabricator.services.mozilla.com/D234616
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1942190
gecko-commit: 1e3dec2f84defef3bd2a8fa9521d14e6b8ff8c35
gecko-reviewers: TYLin