[Gecko Bug 1937188] Restore geolocation permission for wpt geolocation policy tests and make attribute tests more similar #50150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake attribute tests more similar Permission was removed from permissions-policy-geolocation.html upstream but not re-added to the individual tests. These two tests need it. They were incorrectly passing in CI due to the tests that run before them (disabled-by-permissions-policy.https.sub.html) granting the permission -- they would fail when run individually. This also does some cosmetic cleanup to make it clear that the tests are very similar. This includes renaming the tests from "Geolocation API" to "Geolocation", as the name was changed in Bug 1902628 [wpt PR 46750]. Additionally, enabled-by-permission-policy-attribute fails in test-verify mode as an async_test -- the async setup function is not compatible with that. enabled-by-permission-policy-attribute-redirect-on-load is the same test but with a redirect -- it is a promise_test. This switches enabled-by-permission-policy-attribute to work as a promise_test, which fixes the test-verify issue. Differential Revision: https://phabricator.services.mozilla.com/D232772 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1937188 gecko-commit: 2ad450615824e0e0ba0d95e928a8d3e0d59c2f9e gecko-reviewers: saschanaz, jgraham
wpt-pr-bot
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permission was removed from permissions-policy-geolocation.html upstream but not
re-added to the individual tests. These two tests need it. They were
incorrectly passing in CI due to the tests that run before them
(disabled-by-permissions-policy.https.sub.html) granting the permission --
they would fail when run individually.
This also does some cosmetic cleanup to make it clear that the tests are
very similar. This includes renaming the tests from "Geolocation API"
to "Geolocation", as the name was changed in Bug 1902628 [wpt PR 46750].
Additionally, enabled-by-permission-policy-attribute fails in test-verify mode
as an async_test -- the async setup function is not compatible with
that. enabled-by-permission-policy-attribute-redirect-on-load
is the same test but with a redirect -- it is a promise_test. This
switches enabled-by-permission-policy-attribute to work as a promise_test,
which fixes the test-verify issue.
Differential Revision: https://phabricator.services.mozilla.com/D232772
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1937188
gecko-commit: 2ad450615824e0e0ba0d95e928a8d3e0d59c2f9e
gecko-reviewers: saschanaz, jgraham