Skip to content

Conversation

@jogibear9988
Copy link

…lex objects

@keithamus
Copy link
Member

These do not seem to pass in any of the current browsers. Could you please add some more detail to the description talking about why this is fine, and how the tests are accurate despite no browser returning these results? I think that would help determine their mergeability.

Additionally the test is quite large. Do you think there are ways it can be simplified? Reducing markup, or reducing the number of assertsions perhaps? Or splitting out into multiple tests if possible?

@jogibear9988
Copy link
Author

jogibear9988 commented Feb 10, 2025

it works in firefox if you enable the getBoxQuads api in the settings:

image

Also this API is speced, but no browser has developed or enabled it as default.
(spec: https://www.w3.org/TR/cssom-view-1/#the-geometryutils-interface and https://drafts.csswg.org/cssom-view/#dom-geometryutils-getboxquads)

But I've also created a polyfill, wich would support most of it, should this also be in tests?
https://jogibear9988.github.io/getBoxQuadsPolyfill/

I can look to split into multiple tests. Is it okay if they are in the same file?

@keithamus
Copy link
Member

I can look to split into multiple tests. Is it okay if they are in the same file?

I think in the same file is okay yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants