DOM: Implement ref-counted Observable producer#50723
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Feb 14, 2025
Merged
DOM: Implement ref-counted Observable producer#50723chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6221901
branch
from
01327b8 to
2a854aa
Compare
wpt-pr-bot
approved these changes
Feb 14, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL implements ref-counted producers, which came out of the W3C
TPAC discussions in 2024. After this CL, multiple
ObservableInternalObserverobjects can be associated/registered witha single active
Subscriber. The main meat of this CL involves thelogic managing consumer unsubscription, to ensure that only once all
associated consumers/observers unsubscribe do we actually close down
a
Subscriber.See WICG/observable#197.
R=masonf
Bug: 363015168
Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1420647}