DOM: Implement finally() Observable operator#50885
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Feb 21, 2025
Merged
DOM: Implement finally() Observable operator#50885chromium-wpt-export-bot merged 1 commit intomasterfrom
finally() Observable operator#50885chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
See WICG/observable#153. This CL implements the `finally()` operator. It registers a callback which runs on both producer-initiated and consumer-initiated unsubscription. Its implementation is relatively straightforward, just utilizing the relevant subscriber's teardown list. This CL used to be really complicated, as was the spec PR. This has all been simplified since the factors that made it complicated (and broken) have been landed. See: - WICG/observable#151 (comment) - WICG/observable#154 - https://crrev.com/c/5676226 Now that the simplifying factors have been landed, this CL can proceed with a simple implementation, which passes all of the tests. R=dizhangg@chromium.org Bug: 40282760 Change-Id: Ifff220ec094abd2187f35020eae85c1bca502f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5654720 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423349}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5654720
branch
from
bbdf339 to
75543f0
Compare
wpt-pr-bot
approved these changes
Feb 21, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See WICG/observable#153. This CL implements the
finally()operator. It registers a callback which runs on bothproducer-initiated and consumer-initiated unsubscription. Its
implementation is relatively straightforward, just utilizing the
relevant subscriber's teardown list.
This CL used to be really complicated, as was the spec PR. This has all
been simplified since the factors that made it complicated (and broken)
have been landed. See:
finally()operator timing semantics WICG/observable#151 (comment)SubscriberWICG/observable#154Now that the simplifying factors have been landed, this CL can proceed
with a simple implementation, which passes all of the tests.
R=dizhangg@chromium.org
Bug: 40282760
Change-Id: Ifff220ec094abd2187f35020eae85c1bca502f89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5654720
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1423349}