Skip to content

WIP: Add many URL tests to form-validation-checkValidity.html #51011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sideshowbarker
Copy link
Member

Don’t merge this. Just pushing it here for now for others to test with.

@annevk
Copy link
Member

annevk commented Feb 28, 2025

It would be good to have an HTML issue to discuss this. I suspect what we want is that implementations only have to run the URL parser and when that returns failure only then is there a problem. So they don't actually "validate" the URL in order to determine input validity. And then separately we need to figure out what gets submitted and what value ends up returning.

@sideshowbarker
Copy link
Member Author

sideshowbarker commented Feb 28, 2025

It would be good to have an HTML issue to discuss this.

Raised whatwg/html#11083

I suspect what we want is that implementations only have to run the URL parser and when that returns failure only then is there a problem.

Right. That seems to me to be the case — based on having taken the tests added in this PR and run them in Safari and Chrome and Firefox.

So they don't actually "validate" the URL in order to determine input validity.

Right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants