taskcluster: use Firefox from Mozilla PPA in docker image #51185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@jgraham : just a ping to move to see if this can move foward. I was on vacation the last week and couldn't follow up. |
The default apt package for Firefox in Ubuntu 22.04 is just a reference to a snap package and requires explicitly installing firefox using `snap install firefox`. However, snap doesn't work inside docker containers as it requires other services like systemd and snapd to be enabled and running. After moving to 22.04 in web-platform-tests#51161, the missing firefox package causes failure in CI integration tests, specifically 'tests/test_wpt.py': ``` /usr/lib/python3.8/subprocess.py: CalledProcessError ----------------------------- Captured stderr call ----------------------------- Command '/usr/bin/firefox' requires the firefox snap to be installed. Please install it with: snap install firefox ``` As a workaround, this patch adds Mozilla's PPA as an apt source and gives it higher priority than the default package. This has been tested locally and the integration test now passes with this patch. Signed-off-by: Mukilan Thiyagarajan <[email protected]>
mukilan
force-pushed
the
taskcluster-docker-install-firefox-from-ppa
branch
from
a5d2aed to
aefbbf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default apt package for Firefox in Ubuntu 22.04 is just a reference to a snap package and requires explicitly installing firefox using
snap install firefox. However, snap doesn't work inside docker containers as it requires other services like systemd and snapd to be enabled and running.After moving to 22.04 in #51161, the missing firefox package causes failure in CI integration tests, specifically 'tests/test_wpt.py':
As a workaround, this patch adds Mozilla's PPA as an apt source and gives it higher priority than the default package. This has been tested locally and the integration test now passes with this patch.