Add estimate parameter to update_virtual_pressure_source #51194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
testdriver.js
wptrunner
|
@foolip ptal. |
|
I think it's just that people are busy and haven't gotten around to reviewing this yet. I will try to get to it before the end of the week if nobody beats me to it. Have you looked at the infrastructure test failures? |
|
@past I don't see any obvious correlation between the infrastructure test failures and my patch. But I've tested this patch with my upcoming changes on Chromium and it seems to work as intended. I noticed that many other PR are failing on exactly the same infra tests. |
spec PR: w3c/compute-pressure#305 This PR add own pressure estimate parameter to the update_virtual_pressure_source command as specified in https://w3c.github.io/compute-pressure/?experimental=1#update-virtual-pressure-source
There was a clear mistake in updating update_virtual_sensor instead of update_virtual_pressure_source in testdriver-extra.js
arskama
force-pushed
the
ownContributionEstimate
branch
from
d855392 to
455d6bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec PR: w3c/compute-pressure#305
This PR add own pressure estimate parameter to the update_virtual_pressure_source command as specified in https://w3c.github.io/compute-pressure/?experimental=1#update-virtual-pressure-source