Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support single-value <select> elements #51367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support single-value <select> elements #51367

wants to merge 1 commit into from
+1 −1

Conversation

servo-wpt-sync
Copy link
Collaborator

@servo-wpt-sync servo-wpt-sync commented Mar 14, 2025 •
edited
Loading

selectcut.mp4

Among other things this adds a new EmbedderMsg::ShowSelectElementMenu to tell the embedder to display a select popup at the given location.

This is a draft because some small style adjustments need to be made:

  • the select element should always have the width of the largest option
  • the border should be part of the shadow tree

Apart from that, it's mostly ready for review.

HTML for demo video 
<html>

<body>
<select id="c" name="choice">
  <option value="first">First Value</option>
  <option value="second">Second Value</option>
  <option value="third">Third Value</option>
</select>
</body>
</html>

Reviewed in servo/servo#35684

@servo-wpt-sync servo-wpt-sync mentioned this pull request Mar 14, 2025
Open
5 tasks
wpt-pr-bot
wpt-pr-bot approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_35684 branch 4 times, most recently from fb1daa3 to ba9c69a Compare March 18, 2025 14:25
@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_35684 branch 2 times, most recently from c526b32 to 61a594a Compare March 25, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
do not merge yet html servo-export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@servo-wpt-sync @wpt-pr-bot @simonwuelker