Skip to content

Add Web Platform Tests for Digital Credentials Issuance API #51492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohamedamir
Copy link
Contributor

@mohamedamir mohamedamir commented Mar 20, 2025

This PR adds web platform tests for Digital Credentials Issuance API (.create()) that are aligned with the set of test we have for the presentation API (.get())

tests for w3c-fedid/digital-credentials#204

policy: `digital-credentials-get ${hostInfo.HTTPS_REMOTE_ORIGIN}`,
crossOrigin: true,
expectIsAllowed: true,
},
{
Copy link
Contributor

@marcoscaceres marcoscaceres Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I feel we should split this into two tests... I like the addition of action. That's a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't understand your suggestion.
Could you please elaborate more on how you would like to split this?

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from splitting the files, the rest all looks great.

@mohamedamir mohamedamir force-pushed the digital-credentials-issuance-wpt branch from 0bdba7b to 9a866b1 Compare March 27, 2025 11:55
@mohamedamir mohamedamir marked this pull request as draft March 27, 2025 12:03
@mohamedamir mohamedamir marked this pull request as ready for review March 27, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants