-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add Web Platform Tests for Digital Credentials Issuance API #51492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web Platform Tests for Digital Credentials Issuance API #51492
Conversation
policy: `digital-credentials-get ${hostInfo.HTTPS_REMOTE_ORIGIN}`, | ||
crossOrigin: true, | ||
expectIsAllowed: true, | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I feel we should split this into two tests... I like the addition of action. That's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I don't understand your suggestion.
Could you please elaborate more on how you would like to split this?
digital-credentials/disabled-by-permissions-policy.https.sub.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from splitting the files, the rest all looks great.
7f9a76c
to
c55b899
Compare
0bdba7b
to
9a866b1
Compare
This PR adds web platform tests for Digital Credentials Issuance API (.create()) that are aligned with the set of test we have for the presentation API (.get())
tests for w3c-fedid/digital-credentials#204