Add Web Platform Tests for Digital Credentials Issuance API #51492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedamir
commented
Mar 20, 2025
Comment on lines
+45
to
+71
| }, "Permissions-Policy is by default 'self' for get()."); | ||
|
|
||
| promise_test(async (test) => { | ||
| await test_driver.bless("user activation"); | ||
| await promise_rejects_js( | ||
| test, | ||
| TypeError, | ||
| navigator.credentials.create(makeCreateOptions([])) | ||
| ); | ||
|
|
||
| await test_feature_availability({ | ||
| feature_description: "Digital Credential API", | ||
| test, | ||
| src: create_same_origin_src, | ||
| expect_feature_available: expect_feature_available_default, | ||
| is_promise_test: true, | ||
| }); | ||
|
|
||
| await test_feature_availability({ | ||
| feature_description: "Digital Credential API", | ||
| test, | ||
| src: create_cross_origin_src, | ||
| expect_feature_available: expect_feature_unavailable_default, | ||
| feature_name: "digital-credentials-create", | ||
| is_promise_test: true, | ||
| }); | ||
| }, "Permissions-Policy is by default 'self' for create()."); |
There was a problem hiding this comment.
Are we going to introduce a permission policy for issuance too?
I assumed yes in this PR.
Can also come at a later point if this isn't the case!
There was a problem hiding this comment.
yes, exactly... it's the "digital-credentials-create".
| policy: `digital-credentials-get ${hostInfo.HTTPS_REMOTE_ORIGIN}`, | ||
| crossOrigin: true, | ||
| expectIsAllowed: true, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Oh, I feel we should split this into two tests... I like the addition of action. That's a good idea.
| const { HTTPS_REMOTE_ORIGIN } = get_host_info(); | ||
| const same_origin_src = | ||
| const get_same_origin_src = |
There was a problem hiding this comment.
I think we should split this into two files, tbh... otherwise it's going to get confusing if the file continues to grow.
marcoscaceres
requested changes
Mar 25, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds web platform tests for Digital Credentials Issuance API (.create()) that are aligned with the set of test we have for the presentation API (.get())
tests for WICG/digital-credentials#204