[Gecko Bug 1955146] Make WhiteSpaceVisibilityKeeper::MergeFirstLineOfRightBlockElementIntoAncestorLeftBlockElement ignore empty Text nodes when scanning first character of the right block
#51517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toAncestorLeftBlockElement` ignore empty `Text` nodes when scanning first character of the right block Although, the empty text should've been removed, but it may happen without the normalization. Therefore, the lambda should keep scanning the first visible char with ignoring empty `Text` nodes. Additionally, there are similar methods which have the same lambda. Therefore, this fixes them too. I think we should make the scanner method take an option parameter to ignore empty `Text` in a follow up bug. Differential Revision: https://phabricator.services.mozilla.com/D242264 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1955146 gecko-commit: 7a66a04b4fb05629534038b1325f0210c32c58e9 gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although, the empty text should've been removed, but it may happen without the
normalization. Therefore, the lambda should keep scanning the first visible
char with ignoring empty
Textnodes.Additionally, there are similar methods which have the same lambda. Therefore,
this fixes them too.
I think we should make the scanner method take an option parameter to ignore
empty
Textin a follow up bug.Differential Revision: https://phabricator.services.mozilla.com/D242264
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1955146
gecko-commit: 7a66a04b4fb05629534038b1325f0210c32c58e9
gecko-reviewers: m_kato