[Gecko Bug 1955626] Fix WPT scroll-start-overflow-toggled.tentative.html to properly await a requestAnimationFrame callback. #51525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t a requestAnimationFrame callback. The pattern that the test was using, "await requestAnimationFrame", does nothing because requestAnimationFrame doesn't return a Promise that could be awaited. To actually use 'await' to allow a requestAnimationFrame tick to pass, you need to add your own Promise that gets resolved in requestAnimationFrame's callback, as amended in this patch. Differential Revision: https://phabricator.services.mozilla.com/D242551 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1955626 gecko-commit: 015e17880a341c5a017a978a16d3b8ff3de2ca9c gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern that the test was using, "await requestAnimationFrame", does
nothing because requestAnimationFrame doesn't return a Promise that could
be awaited.
To actually use 'await' to allow a requestAnimationFrame tick to pass, you need
to add your own Promise that gets resolved in requestAnimationFrame's callback,
as amended in this patch.
Differential Revision: https://phabricator.services.mozilla.com/D242551
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1955626
gecko-commit: 015e17880a341c5a017a978a16d3b8ff3de2ca9c
gecko-reviewers: emilio