Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPTs for not dispatching cookiechange event when setting already-expired cookie #51527

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 21, 2025

Already expired cookies should not cause cookiechange events to be
dispatched. This CL adds tests to verify this for HTTP cookies,
document.cookie, and the CookieStore API.

This CL only covers cookiechange events being not dispatched to
listeners in the DOM, I will add tests for service workers in a
separate CL.

Bug: 405165851
Change-Id: I023ca8cceb527228951382a1400a18d3dd7218e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378643
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1436296}

…expired cookie

Already expired cookies should not cause cookiechange events to be
dispatched. This CL adds tests to verify this for HTTP cookies,
document.cookie, and the CookieStore API.

This CL only covers cookiechange events being not dispatched to
listeners in the DOM, I will add tests for service workers in a
separate CL.

Bug: 405165851
Change-Id: I023ca8cceb527228951382a1400a18d3dd7218e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378643
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1436296}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jonathan-j-lee
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --verify-log-full --no-headless --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/cookie-store/change_eventhandler_for_document_cookie.https.window.html CookieStore set/overwrite/delete observed by document.cookie FAIL: 1/10, PASS: 9/10 assert_equals: Cookie we wrote using CookieStore is observed: number of changed cookies expected 1 but got 0

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@jonathan-j-lee
Copy link
Contributor

Left a comment (https://crbug.com/405165851#comment3). Please force merge @jcscottiii or @KyleJu. Thanks!

@KyleJu KyleJu merged commit 7dad1ce into master Mar 24, 2025
19 of 21 checks passed
@KyleJu KyleJu deleted the chromium-export-cl-6378643 branch March 24, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants