-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Initial Model element tests #51667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Initial Model element tests #51667
Conversation
… the HTML Model element." This reverts commit 44151c0.
Not an exhaustive suite, but one that covers content types and relevant global attributes.
html/semantics/embedded-content/the-model-element/attributes/global/draggable.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-model-element/attributes/global/draggable.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-model-element/attributes/global/draggable.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-model-element/attributes/global/draggable.html
Outdated
Show resolved
Hide resolved
Until the |
…lobal/draggable.html Co-authored-by: Marcos Cáceres <[email protected]>
…lobal/draggable.html Co-authored-by: Marcos Cáceres <[email protected]>
…lobal/draggable.html Co-authored-by: Marcos Cáceres <[email protected]>
…lobal/draggable.html Co-authored-by: Marcos Cáceres <[email protected]>
changed the tests (but not the refs) to `tentative`
In case you haven't used this pattern before, Anne means the filenames in the PR should change from |
That makes sense - is that correctly addressed here? 3e57b2e |
Potential nit, a couple of the files end in
|
After a recent discussion it was likely decided to make Thus files should have a |
I had thought I was following an established pattern but think I had misread the situation, I've updated now. |
I agree that it should - the only question I have here is whether those tests are about running in HTTPS rather than merely interacting with something that otherwise happens to be HTTPS-dependent. The tests in question aren't even required to load content at this stage, and presumably the DOM-facing container needs to function even if the content-load fails. What do you think? |
Got it. That makes sense to draw a distinction on tests that would require https, e.g. a successful load, etc. and reserve .https.html for those. |
A collection of semantic tests for the basic presence and web-platform functionality of the proposed HTML Model element, in development and discussion at
https://github.com/immersive-web/model-element/
and discussed with WHATWG here:
whatwg/html#10901
These tests are intended to accompany a PR to the WHATWG HTML specification to include
HTMLModelElement
as a new element, with further detail to be added upon TAG review and implementer updates.As an initial pass, we aim to establish:
This effort has support from WebKit, Meta Quest Browser and Samsung internet.
(cc @LaszloGombos, @cabanier, @marcoscaceres, @AdaRoseCannon)