Skip to content

Initial Model element tests #51667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zachernuk
Copy link

A collection of semantic tests for the basic presence and web-platform functionality of the proposed HTML Model element, in development and discussion at
https://github.com/immersive-web/model-element/
and discussed with WHATWG here:
whatwg/html#10901
These tests are intended to accompany a PR to the WHATWG HTML specification to include HTMLModelElement as a new element, with further detail to be added upon TAG review and implementer updates.

As an initial pass, we aim to establish:

  • HTMLModel as a distinct element
  • The expected content model categories
  • The relevant global attribute behaviors

This effort has support from WebKit, Meta Quest Browser and Samsung internet.

(cc @LaszloGombos, @cabanier, @marcoscaceres, @AdaRoseCannon)

Not an exhaustive suite, but one that covers content types and relevant global attributes.
@domenic domenic removed their request for review March 28, 2025 05:00
@annevk
Copy link
Member

annevk commented Apr 4, 2025

Until the model element is part of the HTML standard should mark these tests as .tentative I think.

zachernuk and others added 5 commits April 4, 2025 11:10
changed the tests (but not the refs) to `tentative`
@cookiecrook
Copy link
Contributor

cookiecrook commented Apr 4, 2025

Until the model element is part of the HTML standard should mark these tests as .tentative I think.

In case you haven't used this pattern before, Anne means the filenames in the PR should change from draggable.html to draggable.tentative.html for example. There are other patterns, like .optional for RFC-2119 MAY requirements.

@zachernuk
Copy link
Author

Until the model element is part of the HTML standard should mark these tests as .tentative I think.

In case you haven't used this pattern before, Anne means the filenames in the PR should change from draggable.html to draggable.tentative.html for example. There are other patterns, like .optional for RFC-2119 MAY requirements.

That makes sense - is that correctly addressed here? 3e57b2e

@mkeblx
Copy link

mkeblx commented Apr 17, 2025

Potential nit, a couple of the files end in .htm. I don't know if there is a functional reason for this.

% fd -e html | wc -l
   57946
% fd -e htm | wc -l 
     687

@mkeblx
Copy link

mkeblx commented Apr 17, 2025

After a recent discussion it was likely decided to make model element require HTTPS:
immersive-web/model-element#109 (comment)

Thus files should have a https.html extension (https://web-platform-tests.org/writing-tests/general-guidelines.html#https)

@zachernuk
Copy link
Author

Potential nit, a couple of the files end in .htm. I don't know if there is a functional reason for this.

% fd -e html | wc -l
   57946
% fd -e htm | wc -l 
     687

I had thought I was following an established pattern but think I had misread the situation, I've updated now.

@zachernuk
Copy link
Author

After a recent discussion it was likely decided to make model element require HTTPS: immersive-web/model-element#109 (comment)

Thus files should have a https.html extension (https://web-platform-tests.org/writing-tests/general-guidelines.html#https)

I agree that it should - the only question I have here is whether those tests are about running in HTTPS rather than merely interacting with something that otherwise happens to be HTTPS-dependent.

The tests in question aren't even required to load content at this stage, and presumably the DOM-facing container needs to function even if the content-load fails. What do you think?

@mkeblx
Copy link

mkeblx commented Apr 18, 2025

Got it. That makes sense to draw a distinction on tests that would require https, e.g. a successful load, etc. and reserve .https.html for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants