layout: Implement quote depth calculation for CSS quotes
#52501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
wpt-pr-bot
approved these changes
May 13, 2025
servo-wpt-sync
force-pushed
the
servo_export_36998
branch
3 times, most recently
from
967238b to
21247bd
Compare
Signed-off-by: saku <[email protected]>
Signed-off-by: saku <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_36998
branch
from
21247bd to
2e7f04c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a supplement to the initial CSS quotes implementation (servo/servo#34770) and implements CSS quotes depth calculation. It also addresses the other issue related to depth calculation. (servo/servo#36686)
::before::aftercontent-based quotes (content: open-quote "Test1" close-quote;in::beforewas only supported in initial, but now supports::aftercontent: open-quote;&::beforecontent: close-quote;way.)close-quoteif the depth is 0no-open-quoteandno-close-quoteaccording to the specHowever, this PR has the problem that the calculation sometimes fails and sometimes succeeds. The fail/success timing depends on the layout, and I suspect that the problem is not the calculation logic itself.
I gess the underlying problem would be the parallelization of reflow step.
It'd be great if I could get your opinion on whether the potential problem should be solved in this PR or could be a pending for the future.
Testing: A new reftest is added. (
css/css-content/content-quotes-depth.html) However, the test is currently marked as FAIL since it's flaky because of the reason previously mentioned.Fixes: servo/servo#36686
Reviewed in servo/servo#36998