[wdspec] test browser.createUserContext:proxy parameter
#52691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
DanielRyanSmith,
foolip,
jgraham,
juliandescottes,
shs96c and
whimboo
sadym-chromium
force-pushed
the
sadym/userContext.proxy
branch
from
636bbfa to
ef1358b
Compare
lutien
reviewed
May 21, 2025
|
|
||
|
|
||
| @pytest.fixture | ||
| def create_user_context_with_proxy_and_assert_it_is_created(bidi_session, |
There was a problem hiding this comment.
I'm not sure if you have already an idea how to test all the proxy types. I personally only have an idea about manual type and maybe direct (but only in combination with global proxy set to manual). So maybe it makes sense to keep this fixture as to assert that a user context is created and have a custom logic to verify that proxy applies in each case?
sadym-chromium
force-pushed
the
sadym/userContext.proxy
branch
from
28806fe to
492dbc7
Compare
Lightning00Blade
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: w3c/webdriver-bidi#897