Skip to content

[ident] Support ident() in container/container-name #52700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 21, 2025

This CL adds support for ident() in the container and container-name
properties.

Since the behavior within at-rule preludes is not specified [1],
this CL just includes a basic crash test for "@container ident(...)"
as a provisional safeguard.

[1] w3c/csswg-drafts#12219

Bug: 384930424
Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1463950}

This CL adds support for ident() in the container and container-name
properties.

Since the behavior within at-rule preludes is not specified [1],
this CL just includes a basic crash test for "@container ident(...)"
as a provisional safeguard.

[1] w3c/csswg-drafts#12219

Bug: 384930424
Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1463950}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-6574640 branch from 2d95146 to 96ee509 Compare May 22, 2025 09:08
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 742db34 into master May 22, 2025
16 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6574640 branch May 22, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants