[ident] Support ident() in container/container-name #52700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1463950}
wpt-pr-bot
approved these changes
May 22, 2025
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6574640
branch
from
2d95146 to
96ee509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for ident() in the container and container-name
properties.
Since the behavior within at-rule preludes is not specified [1],
this CL just includes a basic crash test for "@container ident(...)"
as a provisional safeguard.
[1] w3c/csswg-drafts#12219
Bug: 384930424
Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1463950}