Skip to content

Change server names from http[s]-private to http[s]-local. #52711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

hubertchao
Copy link
Contributor

The private IP address namespace was introduced to support Private Network Access(PNA), which never fully launched and is being replaced with Local Network Access(LNA), which has different names for the IP address namespaces.

PNA | LNA

local | loopback
private | local
public | public

LNA: https://github.com/explainers-by-googlers/local-network-access
PNA: https://github.com/WICG/private-network-access/blob/main/explainer.md

The `private` IP address namespace was introduced to support
Private Network Access(PNA), which never fully launched and is
being replaced with Local Network Access(LNA), which has different
names for the IP address namespaces.

PNA     | LNA
-------------------
local   | loopback
private | local
public  | public

LNA: https://github.com/explainers-by-googlers/local-network-access
PNA: https://github.com/WICG/private-network-access/blob/main/explainer.md
@wpt-pr-bot wpt-pr-bot added fetch infra serve wptrunner The automated test runner, commonly called through ./wpt run labels May 22, 2025
Copy link
Contributor

@jonathan-j-lee jonathan-j-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I don't think this rename rises to the level of an RFC, as only a handful tests currently substitute for {{ports[http(s)-private][0]}}.

@jonathan-j-lee
Copy link
Contributor

@jcscottiii or @DanielRyanSmith: Please force merge, thanks!

This PR doesn't change the behavior of the unstable test blocking CI, which has always timed out occaisionally:

image

@jdm jdm merged commit 5c28beb into web-platform-tests:master May 23, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetch infra serve wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants