Named container queries should query the composed tree - #54612
Merged
lilles merged 2 commits intoSep 9, 2025
Merged
Conversation
Contributor
Author
|
cc @lilles who originally wrote these tests |
Member
|
Ideally, the spec change should land first. |
Member
|
Spec PR: w3c/csswg-drafts#12720 |
lilles
requested changes
Sep 3, 2025
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: #54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 4, 2025
Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: web-platform-tests/wpt#54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1510774}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: #54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1510774}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: #54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1510774}
Contributor
Author
|
Are you working on the Blink/Chrome implementation? If so, I just wanted to point out that it appears that Chrome is failing three tests with this update, instead of two like webkit (and which I expected). Seems to be related to that one test that used background-color. |
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 8, 2025
…nd a flag, a=testonly Automatic update from web-platform-tests Make container-name not tree-scoped behind a flag Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: web-platform-tests/wpt#54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1510774} -- wpt-commits: a16c8bf8dfe6e35584d59a639086d433ab67a256 wpt-pr: 54665
lilles
approved these changes
Sep 9, 2025
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 9, 2025
…nd a flag, a=testonly Automatic update from web-platform-tests Make container-name not tree-scoped behind a flag Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: web-platform-tests/wpt#54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/main{#1510774} -- wpt-commits: a16c8bf8dfe6e35584d59a639086d433ab67a256 wpt-pr: 54665 UltraBlame original commit: bf4744b3095e992a8d16464083fe4f1ccfd8bdf3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 9, 2025
…nd a flag, a=testonly Automatic update from web-platform-tests Make container-name not tree-scoped behind a flag Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: web-platform-tests/wpt#54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/main{#1510774} -- wpt-commits: a16c8bf8dfe6e35584d59a639086d433ab67a256 wpt-pr: 54665 UltraBlame original commit: bf4744b3095e992a8d16464083fe4f1ccfd8bdf3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 9, 2025
…nd a flag, a=testonly Automatic update from web-platform-tests Make container-name not tree-scoped behind a flag Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: web-platform-tests/wpt#54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/main{#1510774} -- wpt-commits: a16c8bf8dfe6e35584d59a639086d433ab67a256 wpt-pr: 54665 UltraBlame original commit: bf4744b3095e992a8d16464083fe4f1ccfd8bdf3
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
Per spec resolution: w3c/csswg-drafts#12090 (comment) Not changing container-for-shadow-dom.html in this CL because there is an upstream PR in progress: web-platform-tests#54612 Bug: 440049800 Change-Id: I8b463d798b6132b0bf8932b8152682959907af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909530 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1510774}
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
…tests#54612) * Named container queries should query the composed tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was recently resolved that named containers are NOT tree scoped. The original WPTs asserted that they were.
I've updated the tests to assert that named container queries are not scoped, though these tests are quite tricky so please triple check me here 🙂
Note that this inverts some of the existing results; namely, Firefox now passes all the tests (because it always resolved against the composed tree), and Blink/Webkit now fail those tests that Firefox now passes.