Use the intended reference file for word-spacing-002.html - #54658
Merged
Conversation
wpt-pr-bot
requested review from
fantasai,
frivoal,
kojiishi,
nox,
plinss and
xfq
September 3, 2025 09:04
jfkthame
enabled auto-merge (squash)
September 4, 2025 21:59
jfkthame
force-pushed
the
word-spacing-002-fix
branch
2 times, most recently
from
September 8, 2025 09:24
6b1f125 to
30ab5ff
Compare
Contributor
Author
|
@kojiishi thanks for the review! Do you know what to do about the failing wpt-decision-task check, which appears to be blocking this from merging? I have no idea what's wrong there... |
Contributor
Contributor
|
@jfkthame you could try removing tags from the description. |
jfkthame
force-pushed
the
word-spacing-002-fix
branch
2 times, most recently
from
September 8, 2025 12:26
91b66e5 to
294eb66
Compare
jfkthame
marked this pull request as draft
September 8, 2025 12:31
auto-merge was automatically disabled
September 8, 2025 12:31
Pull request was converted to draft
jfkthame
marked this pull request as ready for review
September 8, 2025 12:32
AFAICS, this test has been broken ever since it was imported from webkit. The original webkit commit included a word-spacing-002-expected.html file (see WebKit commit 6abbfb00701a455534e7d9af010909a6dc2b66ed) clearly intended as a reference (and maybe webkit's CI used it as such), but the actual test file links to word-spacing-001-ref.html which can never have matched (it doesn't even have the same number of test lines). The "expected" file didn't make it into WPT at all, and the test has always been failing. This commit imports it (with the name changed to use "ref"), and updates the link in the test appropriately.
jfkthame
force-pushed
the
word-spacing-002-fix
branch
from
September 8, 2025 12:45
294eb66 to
39f2d3b
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 10, 2025
The test was fixed in the upstream[1]. [1] web-platform-tests/wpt#54658 Bug: 40475877 Change-Id: Idb584d18925cf35805d4be855e180ab15c342c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6916902 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1513513}
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
…rm-tests#54658) AFAICS, this test has been broken ever since it was imported from webkit. The original webkit commit included a word-spacing-002-expected.html file (see WebKit commit 6abbfb00701a455534e7d9af010909a6dc2b66ed) clearly intended as a reference (and maybe webkit's CI used it as such), but the actual test file links to word-spacing-001-ref.html which can never have matched (it doesn't even have the same number of test lines). The "expected" file didn't make it into WPT at all, and the test has always been failing. This commit imports it (with the name changed to use "ref"), and updates the link in the test appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICS, this test has been broken ever since it was imported from webkit. The original webkit commit included a word-spacing-002-expected.html file (see WebKit commit 6abbfb00701a455534e7d9af010909a6dc2b66ed) clearly intended as a reference (and maybe webkit's CI used it as such), but the actual test file links to word-spacing-001-ref.html, which can never have matched (it doesn't even have the same number of test lines).
The "expected" file didn't make it into WPT at all, and the test has always been failing. This commit imports it (with the name changed to use "ref"), and updates the link in the test appropriately.