Fix Safari & Safari Technology Preview GitHub Actions runs - #54689
Merged
Conversation
Member
Author
|
Trying to trigger a manual run made me find out that it is even more broken. 😞 |
foolip
approved these changes
Sep 4, 2025
foolip
left a comment
foolip
left a comment
Member
There was a problem hiding this comment.
Thanks for adding a comment, it wasn't obvious without it 🙃
We make the epochs' git-push-output have 40 character commit ids, because actions/checkout allows for ref to be a commit id, but only if it is exactly a 40 character hex string. Then, with that fixed, the Safari & Safari Technology Preview runs should start succeeding, once again able to check code out. Additionally, fix the `fetch-ref` definition so that it works in the not-workflow_run case where the output is empty.
gsnedders
force-pushed
the
safari-epoch-fix
branch
from
September 4, 2025 20:43
98f4314 to
1e21679
Compare
gsnedders
marked this pull request as ready for review
September 4, 2025 20:44
Member
Author
|
https://github.com/web-platform-tests/wpt/actions/runs/17476226595/job/49636646004 managed to run beyond the checkout stage, which shows the triggering should now work. |
Contributor
|
So can this land? The CI failures look unrelated. |
Member
Author
|
I started writing some short triage of what the CI failures were to land this and then got side-tracked, whoops! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make the epochs' git-push-output have 40 character commit ids, because actions/checkout allows for ref to be a commit id, but only if it is exactly a 40 character hex string (c.f. https://github.com/actions/checkout/blob/ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493/src/input-helper.ts#L74).
Then, with that fixed, the Safari & Safari Technology Preview runs should start succeeding, once again able to check code out.