[INTEROP 2025] Add fuzzy diff to backdrop-filter-basic-opacity-2 - #54698
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
September 4, 2025 21:46
This CL adds fuzziness to backdrop-filter-basic-opacity-2, to account for subtle differences in rendering that can occur in different instantiations of the SKIA renderer. Specifically, when blending a color value of 128 with its inverse due to a filter of invert(), the result may be either 128 or 127. Visually, these results are almost identical, and well within tolerance. Extensive investigation has been done into this behavior, and the behavior of the backdrop filter-related render code in both the passing and failing case is identical, and the failure is likely caused by rendering differences closer to the GPU. This should not be considered a failing test. Bug: 40115360, 40181625 Change-Id: I05c70615d6ad8cfef8ebcfd372709170e19298ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6916525 Commit-Queue: Claire Chambers <clchambers@microsoft.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1511163}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6916525
branch
from
September 4, 2025 21:46
fc87c47 to
2f1ed84
Compare
wpt-pr-bot
approved these changes
Sep 4, 2025
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
nt1m
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds fuzziness to backdrop-filter-basic-opacity-2, to account
for subtle differences in rendering that can occur in different
instantiations of the SKIA renderer. Specifically, when blending
a color value of 128 with its inverse due to a filter of invert(),
the result may be either 128 or 127. Visually, these results are
almost identical, and well within tolerance.
Extensive investigation has been done into this behavior, and the
behavior of the backdrop filter-related render code in both the
passing and failing case is identical, and the failure is likely
caused by rendering differences closer to the GPU. This should not
be considered a failing test.
Bug: 40115360, 40181625
Change-Id: I05c70615d6ad8cfef8ebcfd372709170e19298ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6916525
Commit-Queue: Claire Chambers <clchambers@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1511163}