Implement HTMLElement accessKeyLabel - #54704
Merged
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
September 5, 2025 04:15
This patch implements accessKeyLabel API, matching the HTMLElement specification [1]. This CL helps solve the problem where users find it hard to know which accesskey modifier to press. This also improves interoperability with Safari and Firefox, which have already shipped this API. FYI, This implementation is currently behind a runtime flag. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/uzx6kTcS3hY [1] https://html.spec.whatwg.org/multipage/interaction.html#dom-accesskeylabel Bug: 41119923 Change-Id: I5d8dff04189baea410656fed3096a0c876f417fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6865692 Reviewed-by: Jinho Bang <zino@chromium.org> Commit-Queue: YeongHan Kim <soosungp33@gmail.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511307}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6865692
branch
from
September 5, 2025 04:16
524a064 to
efaef9b
Compare
wpt-pr-bot
approved these changes
Sep 5, 2025
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements accessKeyLabel API, matching the HTMLElement
specification [1].
This CL helps solve the problem where users find it hard to know
which accesskey modifier to press.
This also improves interoperability with Safari and Firefox,
which have already shipped this API.
FYI, This implementation is currently behind a runtime flag.
Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/uzx6kTcS3hY
[1] https://html.spec.whatwg.org/multipage/interaction.html#dom-accesskeylabel
Bug: 41119923
Change-Id: I5d8dff04189baea410656fed3096a0c876f417fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6865692
Reviewed-by: Jinho Bang <zino@chromium.org>
Commit-Queue: YeongHan Kim <soosungp33@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511307}