[css-anchor-position-1] Ignore auto margins in combination with position-area and anchor-center - #55460
Merged
fantasai merged 1 commit intoOct 30, 2025
Conversation
wpt-pr-bot
approved these changes
Oct 15, 2025
fantasai
marked this pull request as draft
October 15, 2025 19:38
fantasai
force-pushed
the
position-area-margin-auto
branch
2 times, most recently
from
October 15, 2025 21:22
7779161 to
2b66c7f
Compare
fantasai
force-pushed
the
position-area-margin-auto
branch
from
October 16, 2025 04:17
2b66c7f to
2be81a5
Compare
fantasai
marked this pull request as ready for review
October 16, 2025 04:24
nt1m
approved these changes
Oct 16, 2025
Member
There was a problem hiding this comment.
This matches the recent spec resolution: w3c/csswg-drafts#10258
cc @dshin-moz @emilio @tabatkins @bfgeek in case they want to review the test
webkit-commit-queue
pushed a commit
to fantasai/WebKit
that referenced
this pull request
Oct 16, 2025
…sition-1] https://bugs.webkit.org/show_bug.cgi?id=300823 Reviewed by Alan Baradlay. Converts auto margins to zero when position-area or anchor-center is in effect. See w3c/csswg-drafts#10258 Tests: imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area.html * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area.html: Rewritten. * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-ref.html: Added. web-platform-tests/wpt#55460 * Source/WebCore/rendering/PositionedLayoutConstraints.cpp: (WebCore::PositionedLayoutConstraints::captureInsets): Canonical link: https://commits.webkit.org/301662@main
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Oct 24, 2025
In a somewhat roundabout fashion, the CSSWG resolved on our previous behaviour of disabling auto margins. See: w3c/csswg-drafts#10258 (comment) Tests are in a pending WPT pull: web-platform-tests/wpt#55460 Bug: 374574260 Change-Id: I477270f55449fa0009dc3c4fd0328b3446724119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7064142 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1535372}
fantasai
enabled auto-merge (rebase)
October 30, 2025 05:34
fantasai
disabled auto-merge
October 30, 2025 05:34
fantasai
force-pushed
the
position-area-margin-auto
branch
from
October 30, 2025 16:33
2be81a5 to
e283b4a
Compare
fantasai
enabled auto-merge (rebase)
October 30, 2025 16:34
…ion-area and anchor-center Because the HTML stylesheet for popovers used margins instead of alignment in order to do centering, margin: auto had to be sacrificed. See w3c/csswg-drafts#10258
fantasai
force-pushed
the
position-area-margin-auto
branch
from
October 30, 2025 21:49
e283b4a to
4f803cb
Compare
jmajnert
pushed a commit
to jmajnert/chromium
that referenced
this pull request
Nov 6, 2025
In a somewhat roundabout fashion, the CSSWG resolved on our previous behaviour of disabling auto margins. See: w3c/csswg-drafts#10258 (comment) Tests are in a pending WPT pull: web-platform-tests/wpt#55460 Bug: 374574260 Change-Id: I477270f55449fa0009dc3c4fd0328b3446724119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7064142 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1535372}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the HTML stylesheet for popovers used margins instead of alignment in order to do centering, margin: auto had to be sacrificed. See
w3c/csswg-drafts#10258