[Gap Decorations]: Resolve crash related to collapsed tracks - #55462
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
October 15, 2025 23:27
This CL addresses a bug involving collapsed tracks with grid gap decorations during fragmentation. In crrev.com/c/7000980, we previously skipped building gaps for ranges with collapsed tracks but did not adjust the gap index-to-set structure accordingly. This CL ensures that entries are not added for ranges without sets, which occurs when tracks are collapsed. Bug: 450776548 Change-Id: I3196e279a723fc8a623c678e0188b5f75aa99e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7040524 Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1530515}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7040524
branch
from
October 15, 2025 23:27
c7c910a to
d85a74e
Compare
wpt-pr-bot
approved these changes
Oct 15, 2025
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL addresses a bug involving collapsed tracks with grid gap
decorations during fragmentation. In crrev.com/c/7000980, we previously
skipped building gaps for ranges with collapsed tracks but did not
adjust the gap index-to-set structure accordingly. This CL ensures that
entries are not added for ranges without sets, which occurs when tracks
are collapsed.
Bug: 450776548
Change-Id: I3196e279a723fc8a623c678e0188b5f75aa99e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7040524
Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1530515}