layout: Let min-content size break before each unbreakable segment run - #55466
Closed
servo-wpt-sync wants to merge 1 commit into
Closed
layout: Let min-content size break before each unbreakable segment run#55466servo-wpt-sync wants to merge 1 commit into
servo-wpt-sync wants to merge 1 commit into
Conversation
wpt-pr-bot
approved these changes
Oct 15, 2025
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Collaborator
Author
|
👋 Downstream pull request (servo/servo#39830) no longer contains any upstreamable changes. Closing pull request without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were only allowing a soft wrap opportunity before the first run in a
TextRunSegment, but not before the other runs. For example, this meant that the min-content size of中文中文would be 4ic instead of just 1ic.The change brings the logic in
ContentSizesComputation::process_item()closer toTextRunSegment::layout_into_line_items().Testing: Adding new tests. There is also a new failure because we don't support
word-break: auto-phrase.Fixes: #39728
Reviewed in servo/servo#39830