Refactor: Replace openid4vp with the latest canonical protocol strings in digital credentials WPTs #55850
+13
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedamir
changed the title
|
@marcoscaceres I think we should also update the corresponding strings in WebKit e.g. here |
|
Yes, though we don't support "openid-4vp" at all (it was only to pass the web platform tests)... does Chrome support passing the mdoc string? If yes, maybe we should switch to that as the default, otherwise all WebKit tests will now fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
openid4vp, the canonical protocol identifier are used, namelyopenid4vp-v1-unsigned,openid4vp-v1-signedandopenid4vp-v1-multisignedin the digital credentials web platform tests.This change ensures the tests align with the latest canonical protocol identifier specified in the OpenID4VP specification (Appendix A.1), eliminating potential confusion.