Add new tests for customelementregistry content attribute and specifying null to createEleent and attachShadow per#56108
Merged
Conversation
wpt-pr-bot
requested review from
TakayoshiKochi,
hayatoito,
kojiishi and
snuggs
November 19, 2025 04:01
rniwa
commented
Nov 19, 2025
| </head> | ||
| <body> | ||
| <div id="host-window"><template shadowrootmode="open"><a-b></a-b></template></div> | ||
| <div id="host-null"><template shadowrootmode="open" shadowrootcustomelementregistry=""><a-b></a-b></template></div> |
Contributor
Author
There was a problem hiding this comment.
This was never used in the test.
rniwa
force-pushed
the
add-scoped-custom-element-registry-customelementregistry-attribute
branch
from
November 19, 2025 04:07
72bf811 to
accfde2
Compare
annevk
approved these changes
Nov 19, 2025
Comment on lines
+6
to
+7
| <script src="../../resources/testharness.js"></script> | ||
| <script src="../../resources/testharnessreport.js"></script> |
Member
There was a problem hiding this comment.
Suggested change
| <script src="../../resources/testharness.js"></script> | |
| <script src="../../resources/testharnessreport.js"></script> | |
| <script src="/resources/testharness.js"></script> | |
| <script src="/resources/testharnessreport.js"></script> |
Comment on lines
+6
to
+7
| <script src="../../resources/testharness.js"></script> | ||
| <script src="../../resources/testharnessreport.js"></script> |
Member
There was a problem hiding this comment.
Suggested change
| <script src="../../resources/testharness.js"></script> | |
| <script src="../../resources/testharnessreport.js"></script> | |
| <script src="/resources/testharness.js"></script> | |
| <script src="/resources/testharnessreport.js"></script> |
Comment on lines
+5
to
+6
| <script src="../../resources/testharness.js"></script> | ||
| <script src="../../resources/testharnessreport.js"></script> |
Member
There was a problem hiding this comment.
Suggested change
| <script src="../../resources/testharness.js"></script> | |
| <script src="../../resources/testharnessreport.js"></script> | |
| <script src="/resources/testharness.js"></script> | |
| <script src="/resources/testharnessreport.js"></script> |
…ing null to createEleent and attachShadow per - whatwg/dom#1424 - whatwg/dom#1423 Also update the existing tests to account for the behavior differences.`
rniwa
force-pushed
the
add-scoped-custom-element-registry-customelementregistry-attribute
branch
from
November 19, 2025 17:45
accfde2 to
237753b
Compare
ja-y-son
reviewed
Nov 20, 2025
| assert_equals(doc.createElement(elementName, {customElementRegistry: null}).customElementRegistry, null); | ||
| assert_equals(doc.createElementNS('http://www.w3.org/1999/xhtml', 'div', {customElementRegistry: null}).customElementRegistry, null); | ||
| }, `document.createElement should create a ${elementDescription} with null registry if customElement is set to null`); | ||
|
|
Contributor
There was a problem hiding this comment.
I'd imagine the test for null registry option on createElement to be placed in Document-createElement.html
Contributor
Author
There was a problem hiding this comment.
Let me address these comments in a follow up since the corresponding WebKit change has already landed.
| test((test) => { | ||
| const [doc, win] = makeIframe(test); | ||
| const host = doc.createElement(elementName); | ||
| const shadowRoot = host.attachShadow({mode: 'closed', customElementRegistry: null}) |
Contributor
There was a problem hiding this comment.
ditto, would imagine this to be placed in ShadowRoot-init-customElementRegistry.html
Contributor
There was a problem hiding this comment.
Do we want to create test cases for cross document append where append does upgrade due to element getting registry on adopt?
Contributor
Author
There was a problem hiding this comment.
A good idea. Will do.
Contributor
There was a problem hiding this comment.
Do we want to add tests to ensure the subtree of the element with customelementregistry attribute also has null registry in both HTML and XHTML?
Contributor
Author
There was a problem hiding this comment.
A good idea. Will do.
rniwa
deleted the
add-scoped-custom-element-registry-customelementregistry-attribute
branch
November 20, 2025 02:06
5 tasks
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Nov 25, 2025
Tests: - web-platform-tests/wpt#56108 - web-platform-tests/wpt#56176 Helps with #1413. Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Nov 26, 2025
This makes it possible to have elements with a null custom element registry in a document tree, allowing the registry to be loaded at a later point. (This commit also fixes a couple minor editorial issues.) Tests: web-platform-tests/wpt#56108. Helps with #1413. Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update the existing tests to account for the behavior differences.`