[scoped-registry] Null registry element should get registry on adopt instead of insert#57213
Merged
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7078864
branch
from
January 26, 2026 22:55
f0f4ac6 to
e58e8f9
Compare
chromium-wpt-export-bot
marked this pull request as ready for review
January 27, 2026 03:34
instead of insert It was discussed over TPAC and outlined in whatwg/dom#1423 that we want to set registry on null registry element during adoption instead of insertion of a node. Bug: 448853877 Change-Id: I63b8a7bcef98ead66bd1375c9b1df69d9b9bd597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7078864 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Jayson Chen <jaysonchen@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1574942}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7078864
branch
from
January 27, 2026 03:34
e58e8f9 to
e0aabe6
Compare
wpt-pr-bot
approved these changes
Jan 27, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was discussed over TPAC and outlined in
whatwg/dom#1423 that we want to set registry on
null registry element during adoption instead of insertion of a node.
Bug: 448853877
Change-Id: I63b8a7bcef98ead66bd1375c9b1df69d9b9bd597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7078864
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1574942}