Skip to content

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 29, 2026

When an embed element has no 'src' and no 'type', it represents
nothing. When the 'src' would be changed to non-empty in that state
there would be no LayoutObject, and thus attach was not triggered
for the element.

By-pass the check for a LayoutObject in this case.

Guarded by the "HTMLEmbedElementRepresentsNothingToActive" flag.

Fixed: 479233864
Change-Id: If5bf5cc2684e146dfc56dda02f12e930a134a717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524670
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1576496}

@community-tc-integration
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/RrfqqFHXRxyRLTHT-jus8w/RrfqqFHXRxyRLTHT-jus8w",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/RrfqqFHXRxyRLTHT-jus8w"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/RrfqqFHXRxyRLTHT-jus8w/RrfqqFHXRxyRLTHT-jus8w",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/RrfqqFHXRxyRLTHT-jus8w"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2026-01-29T12:46:23.010Z

@chromium-wpt-export-bot chromium-wpt-export-bot marked this pull request as ready for review January 29, 2026 13:03
When an <embed> element has no 'src' and no 'type', it represents
nothing. When the 'src' would be changed to non-empty in that state
there would be no LayoutObject, and thus attach was not triggered
for the element.

By-pass the check for a LayoutObject in this case.

Guarded by the "HTMLEmbedElementRepresentsNothingToActive" flag.

Fixed: 479233864
Change-Id: If5bf5cc2684e146dfc56dda02f12e930a134a717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524670
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1576496}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jonathan-j-lee
Copy link
Contributor

The <embed> in the PR description causes wpt-decision-task to fail: #53933

@jonathan-j-lee jonathan-j-lee changed the title Don't require a LayoutObject when 'src' changes on an <embed> Don't require a LayoutObject when 'src' changes on an embed Jan 29, 2026
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 804edcc into master Jan 29, 2026
48 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-7524670 branch January 29, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants