Don't require a LayoutObject when 'src' changes on an embed #57409
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an embed element has no 'src' and no 'type', it represents
nothing. When the 'src' would be changed to non-empty in that state
there would be no LayoutObject, and thus attach was not triggered
for the element.
By-pass the check for a LayoutObject in this case.
Guarded by the "HTMLEmbedElementRepresentsNothingToActive" flag.
Fixed: 479233864
Change-Id: If5bf5cc2684e146dfc56dda02f12e930a134a717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524670
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1576496}