Improve select restoration with no matching option #57417
Merged
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that the select element is being restored after navigating backwards and there is a mismatch between the restore state and the current state of the select element, we should make the select element use its default state instead of having no selected option because having no selected option looks broken. Fixed: 41360677 Change-Id: I7e6dced3e77687d5674bcb6d27e5278274d1737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7522897 Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1576590}
wpt-pr-bot
approved these changes
Jan 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the select element is being restored after navigating
backwards and there is a mismatch between the restore state and the
current state of the select element, we should make the select element
use its default state instead of having no selected option because having
no selected option looks broken.
Fixed: 41360677
Change-Id: I7e6dced3e77687d5674bcb6d27e5278274d1737f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7522897
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1576590}