Correctly propagate scroll margin for ancestor scroll into view #57422
+314
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that when clipping the rect to expose, we only consider the actual rect to make visible, and don't clip away the scroll margin or scroll padding. Since we haven't modified the rect to expose, we can keep the scroll margin as we bubble to ancestor scrollers. Bug: 40876429, 40074749 Change-Id: I8b948fccc0aeee58872ab1632ff20901448b21a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7529476 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1576737}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7529476
branch
from
b0edd02 to
d70f54a
Compare
wpt-pr-bot
approved these changes
Jan 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that when clipping the rect to expose,
we only consider the actual rect to make visible, and don't
clip away the scroll margin or scroll padding.
Since we haven't modified the rect to expose, we can keep the
scroll margin as we bubble to ancestor scrollers.
Bug: 40876429, 40074749
Change-Id: I8b948fccc0aeee58872ab1632ff20901448b21a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7529476
Reviewed-by: Vladimir Levin <[email protected]>
Commit-Queue: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1576737}