Skip to content

[Gecko Bug 2020364] Part 3: Check if ongoing navigation is NavigationID. #58484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moz-wptsync-bot wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −2
Open

[Gecko Bug 2020364] Part 3: Check if ongoing navigation is NavigationID. #58484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions navigation-api/precommit-handler/precommitHandler-window-stop-before-commit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
// Wait for after the load event because window.stop() hangs the test harness
// if called before the load event.
await new Promise(resolve => window.onload = () => t.step_timeout(resolve, 0));
}, "Setup");

promise_test(async t => {
navigation.onnavigate = e => {
e.intercept({ precommitHandler: async () => {} });
};
Expand All @@ -20,14 +22,36 @@
assert_equals(location.hash, "");
});

let promises = navigation.navigate("#ShouldNotCommit");
let promises = navigation.navigate("?ShouldNotCommit");
assert_equals(location.hash, "");

window.stop();
await assertBothRejectDOM(t, promises, "AbortError");

assert_equals(location.hash, "");
assert_true(navigateerror_called);
}, " precommitHandler with window.stop() before commit");
}, " precommitHandler with window.stop() before navigation commit");

promise_test(async t => {
navigation.onnavigate = e => {
e.intercept({ precommitHandler: async () => {} });
};

navigation.onnavigateerror = t.unreached_func("onnavigateerror must not fire");
let navigatesuccess_called = false;
navigation.onnavigatesuccess = t.step_func(() => {
navigatesuccess_called = true;
assert_equals(location.hash, "#ShouldCommit");
});

let promises = navigation.navigate("#ShouldCommit");
assert_equals(location.hash, "");

window.stop();
await assertBothFulfillEntryNotAvailable(t, promises);

assert_equals(location.hash, "#ShouldCommit");
assert_true(navigatesuccess_called);
}, " precommitHandler with window.stop() before fragment navigation commit");
</script>
</body>
Loading