Skip to content

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=30397 #58511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlcow merged 1 commit into from
Mar 18, 2026
+65 −0
Merged

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=30397 #58511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions uievents/keyboard/keypress-not-fired-for-modifier-shortcuts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
<!DOCTYPE html>
<meta charset="utf-8" />
<title>UI Events Test: keypress not fired for modifier shortcuts</title>
<link rel="author" title="Karl Dubost" href="https://otsukare.info/">
<link rel="help" href="https://w3c.github.io/uievents/#keypress" />
<meta name="assert" content="This test checks that keypress events are not fired when Control or Meta modifier keys are active, per the UI Events spec.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<div id="target" tabindex="0">Target</div>
<script>
// WebDriver modifier key codes.
const CONTROL = '\uE009';
const META = '\uE03D';

const modifiers = {
"Control": CONTROL,
"Meta": META,
};

target.focus();

for (const [modName, modCode] of Object.entries(modifiers)) {
promise_test(() => {
let keypressFired = false;
return new Promise(resolve => {
function onKeypress() {
keypressFired = true;
}
function onKeyup(event) {
if (event.key !== modName) {
target.removeEventListener("keypress", onKeypress);
target.removeEventListener("keyup", onKeyup);
resolve(keypressFired);
}
}
target.addEventListener("keypress", onKeypress);
target.addEventListener("keyup", onKeyup);
test_driver.send_keys(target, modCode + 'v');
}).then((fired) => {
assert_false(fired, "keypress should not fire for " + modName + "+v");
});
}, `keypress must not be dispatched for ${modName} + v`);
}

promise_test(() => {
let keypressFired = false;
return new Promise(resolve => {
function onKeypress() {
keypressFired = true;
}
function onKeyup(event) {
target.removeEventListener("keypress", onKeypress);
target.removeEventListener("keyup", onKeyup);
resolve(keypressFired);
}
target.addEventListener("keypress", onKeypress);
target.addEventListener("keyup", onKeyup);
test_driver.send_keys(target, 'a');
}).then((fired) => {
assert_true(fired, "keypress should fire for plain 'a'");
});
}, `keypress must be dispatched for a plain key`);
</script>
Loading