Fix progress() internal type#59436
Merged
Merged
Conversation
progress() always return number, but while creating CalculationExpressionNode the result was saved as pixels and percents, which later confused our type system. Fixed: 504004119 Change-Id: I50e7090f63a678e147d99fad8e089aad4b6425fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789613 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1619414}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7789613
branch
from
e20bd29 to
9b22a81
Compare
wpt-pr-bot
approved these changes
Apr 23, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progress() always return number, but while creating
CalculationExpressionNode the result was saved as pixels and percents,
which later confused our type system.
Fixed: 504004119
Change-Id: I50e7090f63a678e147d99fad8e089aad4b6425fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789613
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619414}