[gap-decorations] Implement behavior of overlap-join for "dangling" endpoints#59438
Merged
Merged
Conversation
…ndpoints Widen the edge vs interior endpoint classification for CSS gap decorations. Previously, "edge" meant the endpoint is at the container boundary. The new definition: an endpoint is <TODO> if it has no visible crossing decoration, either because it's at the container boundary (geometric edge) OR because it's an interior intersection where the crossing decoration is hidden (dangling endpoint). This is relevant for rule-visibility-items: between in grid containers, where empty cells can suppress crossing decorations, creating interior intersections that visually "dangle" without anything to join to. Spec discussion: w3c/csswg-drafts#13697. Bug: 357648037 Change-Id: I339b33571c273c3f0c831310f4bd2e3957aaba5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7759394 Commit-Queue: Javier Contreras <javiercon@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1619668}
wpt-pr-bot
approved these changes
Apr 23, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
56e4884 to
bdbf13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the edge vs interior endpoint classification for CSS gap
decorations. Previously, "edge" meant the endpoint is at the container
boundary. The new definition: an endpoint is <TODO> if it has no visible
crossing decoration, either because it's at the container boundary
(geometric edge) OR because it's an interior intersection where the
crossing decoration is hidden (dangling endpoint).
This is relevant for rule-visibility-items: between in grid containers,
where empty cells can suppress crossing decorations, creating interior
intersections that visually "dangle" without anything to join to.
Spec discussion: w3c/csswg-drafts#13697.
Bug: 357648037
Change-Id: I339b33571c273c3f0c831310f4bd2e3957aaba5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7759394
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1619668}